Overhaul FindBrotli to fix weird issues #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should get rid of the issue about not being able to create an ALIAS on MinGW, as well as the "No REQUIRED_VARS" issue. Fixes yhirose#603 (hopefully)
|
@sum01, thanks for the update! |
ottigeda
pushed a commit
to ottigeda/cpp-httplib
that referenced
this pull request
Aug 12, 2020
Should get rid of the issue about not being able to create an ALIAS on MinGW, as well as the "No REQUIRED_VARS" issue. Fixes yhirose#603 (hopefully)
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Should get rid of the issue about not being able to create an ALIAS on MinGW, as well as the "No REQUIRED_VARS" issue. Fixes yhirose#603 (hopefully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should get rid of the issue about not being able to create an ALIAS on
MinGW, as well as the "No REQUIRED_VARS" issue.
Fixes #603 (hopefully)
I tested on regular Windows, Windows with MSYS2 (Unix & Visual Studio generators), and Linux.