Skip to content

Replace the image tag with background-image to preven… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Replace the image tag with background-image to preven… #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
perf[PanThumb]: Replace the image tag with background-image to preven… 
…t the stretching (PanJiaChen#2202)
  • Loading branch information
@mayunhai @PanJiaChen
mayunhai authored and PanJiaChen committed Jun 6, 2019
commit d3a2b6b34ed2f4ba69b78f2d07483747eb6ea7dd
10 changes: 6 additions & 4 deletions src/components/PanThumb/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<slot />
</div>
</div>
<img :src="image" class="pan-thumb">
<!-- eslint-disable-next-line -->
<div :style="{backgroundImage: `url(${image})`}" class="pan-thumb"></div>
</div>
</template>

Expand Down Expand Up @@ -52,15 +53,16 @@ export default {
.pan-thumb {
width: 100%;
height: 100%;
background-size: 100%;
background-position: center center;
background-size: cover;
border-radius: 50%;
overflow: hidden;
position: absolute;
transform-origin: 95% 40%;
transition: all 0.3s ease-in-out;
}

.pan-thumb:after {
/* .pan-thumb:after {
content: '';
width: 8px;
height: 8px;
Expand All @@ -71,7 +73,7 @@ export default {
margin: -4px 0 0 -4px;
background: radial-gradient(ellipse at center, rgba(14, 14, 14, 1) 0%, rgba(125, 126, 125, 1) 100%);
box-shadow: 0 0 1px rgba(255, 255, 255, 0.9);
}
} */

.pan-info {
position: absolute;
Expand Down