Skip to content

Conversation

@mspirkov
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

The access token can be null, but only OAuthToken is specified in the type. Such a situation can definitely happen and it is even checked by tests.

image

In my project, I bypassed this, but I would like to fix the type in the source code.
image

@mspirkov mspirkov marked this pull request as draft April 25, 2025 13:41
@mspirkov mspirkov marked this pull request as ready for review April 25, 2025 13:46
@mspirkov mspirkov changed the title Fix: Nullable type for BaseOAuth property - accessToken Fix type for BaseOAuth property - accessToken Apr 25, 2025
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line for CHANGELOG. Thanks.

@samdark samdark added this to the 2.2.17 milestone Apr 26, 2025
@samdark samdark merged commit 7621d6d into yiisoft:master Apr 26, 2025
0 of 10 checks passed
@samdark
Copy link
Member

samdark commented Apr 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants