Skip to content

Fix crash on saving endpoint (FFUF related only) #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogeshojha merged 9 commits into from
Nov 27, 2023
Merged

Fix crash on saving endpoint (FFUF related only) #1063

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e5bf0c4
Add check & exception catch while saving endpoint
psyray Nov 22, 2023
7b4ee42
Resolve syntax error
psyray Nov 22, 2023
fb28da7
Reduce debug equal sign
psyray Nov 22, 2023
39c6871
Move debug log on error only
psyray Nov 22, 2023
914929f
cast exception text to string
psyray Nov 22, 2023
5c7bb8d
Prevent empty endpoint by getting first endpoint
psyray Nov 22, 2023
e91ca6b
Change method to create only to reduce query
psyray Nov 22, 2023
d12d69b
Remove bad tuple var and set create flag to true
psyray Nov 23, 2023
caa0f2d
Remove comment
psyray Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions web/reNgine/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4495,11 +4495,27 @@ def save_endpoint(
if not validators.url(http_url):
return None, False
http_url = sanitize_url(http_url)
endpoint, created = EndPoint.objects.get_or_create(

# Try to get the first matching record (prevent duplicate error)
endpoints = EndPoint.objects.filter(
scan_history=scan,
target_domain=domain,
http_url=http_url,
**endpoint_data)
**endpoint_data
)

if endpoints.exists():
endpoint = endpoints.first()
created = False
else:
# No existing record, create a new one
endpoint = EndPoint.objects.create(
scan_history=scan,
target_domain=domain,
http_url=http_url,
**endpoint_data
)
created = True

if created:
endpoint.is_default = is_default
Expand Down