Skip to content

Fix error during tool update Fixes #1152 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogeshojha merged 1 commit into from
Jul 30, 2024
Merged

Fix error during tool update Fixes #1152 #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix 500 error during tool update
  • Loading branch information
@yogeshojha
yogeshojha committed Jul 29, 2024
commit f7d0a57fdd84790b3dfa1f1aa0fec8b39a805b02
12 changes: 8 additions & 4 deletions web/api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,10 +982,14 @@ def get(self, request):
tool_name = tool_name.split('/')[-1]
update_command = 'cd /usr/src/github/' + tool_name + ' && git pull && cd -'

run_command(update_command)
run_command.apply_async(args=(update_command,))
return Response({'status': True, 'message': tool.name + ' updated successfully.'})


try:
run_command(update_command, shell=True)
run_command.apply_async(args=[update_command], kwargs={'shell': True})
return Response({'status': True, 'message': tool.name + ' updated successfully.'})
except Exception as e:
logger.error(str(e))
return Response({'status': False, 'message': str(e)})

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.

class GetExternalToolCurrentVersion(APIView):
def get(self, request):
Expand Down