(bug) Fix subdomain import for subdomains with suffix more than 4 chars Fixes #1128 #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
|
👋 Hi @yogeshojha, |
yogeshojha
deleted the
1128-bug-subdomain-import-could-fail-if-suffix-more-than-4-chars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
get_domain_from_subdomainfunction was not accurately handling all types of subdomains, especially those with less common or new TLDs. It also lacked proper validation for the returned domains.This PR introduces a refactored
get_domain_from_subdomainfunction that combines the strengths oftldextract, a custom fallback method.