Skip to content

Zarr data types refactor compat round 2 #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomNicholas merged 38 commits into from
Jul 17, 2025
Merged

Zarr data types refactor compat round 2 #677

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
63ff6c9
fix .dtype property
TomNicholas Jul 15, 2025
e765e13
use zarr data types in create_array_v3_metadata
TomNicholas Jul 15, 2025
c60795a
change expected repr
TomNicholas Jul 15, 2025
b2d9549
fix test for checking dtypes are the same
TomNicholas Jul 15, 2025
a05d9e8
fix icechunk tests
TomNicholas Jul 15, 2025
f172930
fix kerchunk tests
TomNicholas Jul 15, 2025
02dfa56
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 15, 2025
7dfeabe
Merge branch 'develop' into zarr-data-types-refactor-compat2
TomNicholas Jul 15, 2025
b42022f
fix combine test
TomNicholas Jul 15, 2025
7bb6e6f
fix conversion of v3 to v2 metadata
TomNicholas Jul 16, 2025
744fd49
write function to normalize kerchunk references into true json
TomNicholas Jul 16, 2025
35f94b5
use the new function in our tests
TomNicholas Jul 16, 2025
9663d05
remove outdated imports
TomNicholas Jul 16, 2025
e1e54b3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 16, 2025
915e4c3
Merge branch 'develop' into kerchunk_to_true_json
TomNicholas Jul 16, 2025
ae3f871
Merge branch 'kerchunk_to_true_json' into zarr-data-types-refactor-co…
TomNicholas Jul 16, 2025
8548086
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 16, 2025
01baf83
missed a coersion
TomNicholas Jul 16, 2025
ad0be5c
Merge branch 'kerchunk_to_true_json' of https://github.com/TomNichola…
TomNicholas Jul 16, 2025
de9c8fd
Merge branch 'kerchunk_to_true_json' into zarr-data-types-refactor-co…
TomNicholas Jul 16, 2025
35cfddf
fix dmrpp test
TomNicholas Jul 16, 2025
813ee16
Merge branch 'zarr-data-types-refactor-compat2' of https://github.com…
TomNicholas Jul 16, 2025
f0739c1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 16, 2025
77493a6
Merge branch 'develop' into zarr-data-types-refactor-compat2
TomNicholas Jul 16, 2025
31941fb
require latest zarr
TomNicholas Jul 16, 2025
64a513b
Merge branch 'zarr-data-types-refactor-compat2' of https://github.com…
TomNicholas Jul 16, 2025
a17884d
update minimum version in pixi
TomNicholas Jul 16, 2025
93f7758
fix array return type and add test
TomNicholas Jul 17, 2025
407f208
change expected group repr dtype str
TomNicholas Jul 17, 2025
09d801d
fix metadata comparison by just using updated version of ArrayV3Metad…
TomNicholas Jul 17, 2025
9117116
don't need to add .nbytes to ManifestArray
TomNicholas Jul 17, 2025
3ebb731
remove rogue print statements
TomNicholas Jul 17, 2025
bf104cb
try fixing zarr data type error in icechunk writer in CI
TomNicholas Jul 17, 2025
b1961b6
remove xfail now that datetime dtypes are supported in zarr
TomNicholas Jul 17, 2025
b0bddf2
add xfail for one test case
TomNicholas Jul 17, 2025
fc1bd34
add note about now supporting big-endian
TomNicholas Jul 17, 2025
925ffec
remove unnecessary conversion of dtype
TomNicholas Jul 17, 2025
0d7ad60
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix kerchunk tests
  • Loading branch information
@TomNicholas
TomNicholas committed Jul 15, 2025
commit f172930a3af9b396a2349dbab6adf1743f521f67
2 changes: 1 addition & 1 deletion virtualizarr/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def convert_v3_to_v2_metadata(

v2_metadata = ArrayV2Metadata(
shape=v3_metadata.shape,
dtype=v3_metadata.data_type.to_numpy(),
dtype=v3_metadata.data_type,
chunks=v3_metadata.chunks,
fill_value=fill_value or v3_metadata.fill_value,
compressor=compressor_config,
Expand Down
Loading