Skip to content

Apply and enforce more ruff rules #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhamman merged 13 commits into from
Sep 24, 2024
Merged

Apply and enforce more ruff rules #2053

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f2ec3d
Apply ruff/Perflint rule PERF102
DimitriPapadopoulos Sep 7, 2024
c71c532
Apply ruff/Perflint rule PERF401
DimitriPapadopoulos Aug 23, 2024
f462e1e
Apply ruff/flake8-pytest-style rule PT022
DimitriPapadopoulos Sep 24, 2024
47930c4
Fix pre-commit warning
DimitriPapadopoulos Aug 23, 2024
26d17cb
Apply ruff/pygrep-hooks rule PGH003
DimitriPapadopoulos Sep 2, 2024
9c13559
Apply ruff/pygrep-hooks rule PGH004
DimitriPapadopoulos Aug 23, 2024
8a14ef2
Enforce ruff/pygrep-hooks rules (PGH)
DimitriPapadopoulos Aug 23, 2024
3e9c081
Apply ruff/flake8-comprehensions rule C417
DimitriPapadopoulos Aug 23, 2024
58b88a1
Apply ruff/flake8-pyi rule PYI032
DimitriPapadopoulos Aug 23, 2024
1881555
Apply ruff/flake8-pyi rule PYI036
DimitriPapadopoulos Sep 24, 2024
dbadd08
Apply ruff/flake8-pyi rule PYI038
DimitriPapadopoulos Sep 24, 2024
85b7004
Apply ruff/flake8-pyi rule PYI041
DimitriPapadopoulos Aug 23, 2024
eba9d47
Apply ruff/flake8-pyi rule PYI055
DimitriPapadopoulos Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply ruff/flake8-pyi rule PYI036 
PYI036 Returning Any from function
  • Loading branch information
@DimitriPapadopoulos
DimitriPapadopoulos committed Sep 24, 2024
commit 188155515abea4c31a52f13ba41c6df7334ace91
5 changes: 2 additions & 3 deletions tests/v3/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
from zarr.store.remote import RemoteStore

if TYPE_CHECKING:
from collections.abc import Generator, Iterator
from types import ModuleType
from collections.abc import Generator
from typing import Any, Literal

from _pytest.compat import LEGACY_PATH
Expand Down Expand Up @@ -99,7 +98,7 @@ async def async_group(request: pytest.FixtureRequest, tmpdir: LEGACY_PATH) -> As


@pytest.fixture(params=["numpy", "cupy"])
def xp(request: pytest.FixtureRequest) -> Iterator[ModuleType]:
def xp(request: pytest.FixtureRequest) -> Any:
"""Fixture to parametrize over numpy-like libraries"""

if request.param == "cupy":
Expand Down