Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ensure that store_dict used for empty dicts
The `store_dict or {}` is Falsey for empty dicts, so the user provided
dict wasn't being used.
  • Loading branch information
TomAugspurger committed Sep 9, 2024
commit f92dbbf7fcc669589cce23cc41651ca2ee42e0bc
4 changes: 3 additions & 1 deletion src/zarr/store/memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ def __init__(
mode: AccessModeLiteral = "r",
):
super().__init__(mode=mode)
self._store_dict = store_dict or {}
if store_dict is None:
store_dict = {}
self._store_dict = store_dict

async def empty(self) -> bool:
return not self._store_dict
Expand Down
6 changes: 6 additions & 0 deletions tests/v3/test_store/test_memory.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,9 @@ def test_store_supports_partial_writes(self, store: GpuMemoryStore) -> None:

def test_list_prefix(self, store: GpuMemoryStore) -> None:
assert True


def test_uses_dict():
store_dict = {}
store = MemoryStore(store_dict)
assert store._store_dict is store_dict