Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed path segment duplication in open_array
Closes #2166
  • Loading branch information
TomAugspurger committed Sep 10, 2024
commit 99836f0d3f3f7cb5b890d0df6c1faa0ac1194403
1 change: 0 additions & 1 deletion src/zarr/api/asynchronous.py
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,6 @@ async def open_array(
if store_path.store.mode.create:
return await create(
store=store_path,
path=path,
zarr_format=zarr_format,
overwrite=store_path.store.mode.overwrite,
**kwargs,
Expand Down
12 changes: 12 additions & 0 deletions src/zarr/testing/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import pytest

import zarr.api.asynchronous
from zarr.abc.store import AccessMode, Store
from zarr.core.buffer import Buffer, default_buffer_prototype
from zarr.store._utils import _normalize_interval_index
Expand Down Expand Up @@ -232,3 +233,14 @@ async def test_list_dir(self, store: S) -> None:
keys_observed = [k async for k in store.list_dir("group-0/group-1")]
assert len(keys_expected) == len(keys_observed), keys_observed
assert set(keys_observed) == set(keys_expected), keys_observed

async def test_set_get(self, store_kwargs: dict[str, Any]) -> None:
kwargs = {**store_kwargs, **{"mode": "w"}}
store = self.store_cls(**kwargs)
await zarr.api.asynchronous.open_array(store=store, path="a", mode="w", shape=(4,))
keys = [x async for x in store.list()]
assert keys == ["a/zarr.json"]

# no errors
await zarr.api.asynchronous.open_array(store=store, path="a", mode="r")
await zarr.api.asynchronous.open_array(store=store, path="a", mode="a")