Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
jhamman authored Sep 29, 2024
commit 322918a20d559f59027334138e48a90c85ffbaa4
12 changes: 5 additions & 7 deletions src/zarr/api/asynchronous.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ async def open(
"""
zarr_format = _handle_zarr_version_or_format(zarr_version=zarr_version, zarr_format=zarr_format)

store_path = await make_store_path(store, mode=mode)
store_path = await make_store_path(store, mode=mode, storage_options=storage_options)

if path is not None:
store_path = store_path / path
Expand Down Expand Up @@ -323,7 +323,7 @@ async def save_array(
)

mode = kwargs.pop("mode", None)
store_path = await make_store_path(store, mode=mode)
store_path = await make_store_path(store, mode=mode, storage_options=storage_options)
if path is not None:
store_path = store_path / path
new = await AsyncArray.create(
Expand Down Expand Up @@ -502,7 +502,7 @@ async def group(

mode = None if isinstance(store, Store) else cast(AccessModeLiteral, "a")

store_path = await make_store_path(store, mode=mode)
store_path = await make_store_path(store, mode=mode, storage_options=storage_options)
if path is not None:
store_path = store_path / path

Expand Down Expand Up @@ -780,7 +780,7 @@ async def create(
if not isinstance(store, Store | StorePath):
mode = "a"

store_path = await make_store_path(store, mode=mode)
store_path = await make_store_path(store, mode=mode, storage_options=storage_options)
if path is not None:
store_path = store_path / path

Expand Down Expand Up @@ -957,9 +957,7 @@ async def open_array(

mode = kwargs.pop("mode", None)
store_path = await make_store_path(store, mode=mode)
if (
path is not None
): # FIXME: apply path before opening store in w or risk deleting existing data
if path is not None:
store_path = store_path / path

zarr_format = _handle_zarr_version_or_format(zarr_version=zarr_version, zarr_format=zarr_format)
Expand Down
1 change: 0 additions & 1 deletion src/zarr/core/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -2385,7 +2385,6 @@ def chunks_initialized(array: Array | AsyncArray) -> tuple[str, ...]:
def _build_parents(node: AsyncArray | AsyncGroup) -> list[AsyncGroup]:
from zarr.core.group import AsyncGroup, GroupMetadata

print("path", node.store_path.path)

if "/" in node.store_path.path:
required_parts = node.store_path.path.split("/")[:-1]
Expand Down