Default to RemoteStore for fsspec URIs #2198
fixup
- Loading branch information
commit 72fb559dae2ec62d92634777fbbf44c1b090af95
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,6 @@ def __eq__(self, other: Any) -> bool: | |
| async def make_store_path( | ||
| store_like: StoreLike | None, | ||
| *, | ||
| mode: AccessModeLiteral | None = None, | ||
| storage_options: dict[str, Any] | None = None, | ||
| ) -> StorePath: | ||
|
|
@@ -105,7 +104,7 @@ async def make_store_path( | |
| result = StorePath(await LocalStore.open(root=store_like, mode=mode or "r")) | ||
| elif isinstance(store_like, str): | ||
| storage_options = storage_options or {} | ||
| fs, _ = fsspec.url_to_fs(store_like, **storage_options) | ||
|
||
| if "file" not in fs.protocol: | ||
| storage_options = storage_options or {} | ||
| result = StorePath(RemoteStore(url=store_like, mode=mode or "r", **storage_options)) | ||
|
|
@@ -118,8 +117,6 @@ async def make_store_path( | |
| else: | ||
| raise TypeError | ||
|
|
||
| return result | ||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can pass
**storage_optionstoLocalStoreas wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be missing something, but I don't think that'll work.
LocalStore.openwill callLocalStore.__init__, which just takesrootandmode, which are passed as regular args here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. I was thinking
auto_mkdirwould be passed through but if that's not the case, let's not get distracted here.