Skip to content

[v3] Implement Group methods for empty, full, ones, and zeros #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhamman merged 11 commits into from
Sep 19, 2024
Merged

[v3] Implement Group methods for empty, full, ones, and zeros #2210

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c884f1
fill in stubs for Group.{empty,zeros,ones,full,empty_like, zeros_like…
lindseynield Sep 18, 2024
1a3b432
add shape to function signature
lindseynield Sep 18, 2024
c75605e
change type in function signature and add unit tests
lindseynield Sep 18, 2024
8ee9e19
precommit
lindseynield Sep 18, 2024
2ad8b78
small fixes
lindseynield Sep 18, 2024
1d8410d
add shape check to tests
lindseynield Sep 18, 2024
bb32056
update function signatures
lindseynield Sep 18, 2024
fdb7461
cast path to a str
lindseynield Sep 18, 2024
c2379a1
update store path
lindseynield Sep 19, 2024
c4ff153
Merge branch 'v3' into v3
jhamman Sep 19, 2024
15c4d28
Merge branch 'v3' into v3
lindseynield Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add shape to function signature
  • Loading branch information
@lindseynield
lindseynield committed Sep 18, 2024
commit 1a3b432da8709141140871dfd7245998d4b0700b
32 changes: 16 additions & 16 deletions src/zarr/core/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,17 +714,17 @@ async def arrays(self) -> AsyncGenerator[AsyncArray, None]:
async def tree(self, expand: bool = False, level: int | None = None) -> Any:
raise NotImplementedError

async def empty(self, **kwargs: Any) -> AsyncArray:
return await empty(**kwargs)
async def empty(self, shape: ChunkCoords, **kwargs: Any) -> AsyncArray:
return await empty(shape=shape, fill_value=None, **kwargs)

async def zeros(self, **kwargs: Any) -> AsyncArray:
return await zeros(**kwargs)
async def zeros(self, shape: ChunkCoords, **kwargs: Any) -> AsyncArray:
return await zeros(shape=shape, fill_value=0, **kwargs)

async def ones(self, **kwargs: Any) -> AsyncArray:
return await ones(**kwargs)
async def ones(self, shape: ChunkCoords, **kwargs: Any) -> AsyncArray:
return await ones(shape=shape, fill_value=1, **kwargs)

async def full(self, **kwargs: Any) -> AsyncArray:
return await full(**kwargs)
async def full(self, shape: ChunkCoords, fill_value: Any | None, **kwargs: Any) -> AsyncArray:
return await full(shape=shape, fill_value=fill_value, **kwargs)

async def empty_like(self, prototype: AsyncArray, **kwargs: Any) -> AsyncArray:
return await empty_like(prototype, kwargs)
Expand Down Expand Up @@ -1068,17 +1068,17 @@ def require_array(self, name: str, **kwargs: Any) -> Array:
"""
return Array(self._sync(self._async_group.require_array(name, **kwargs)))

def empty(self, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.empty(**kwargs)))
def empty(self, shape: ChunkCoords, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.empty(shape=shape, **kwargs)))

def zeros(self, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.zeros(**kwargs)))
def zeros(self, shape: ChunkCoords, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.zeros(shape=shape, **kwargs)))

def ones(self, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.ones(**kwargs)))
def ones(self, shape: ChunkCoords, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.ones(shape=shape, **kwargs)))

def full(self, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.full(**kwargs)))
def full(self, shape: ChunkCoords, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.full(shape=shape, **kwargs)))

def empty_like(self, prototype: AsyncArray, **kwargs: Any) -> Array:
return Array(self._sync(self._async_group.empty_like(prototype, **kwargs)))
Expand Down