Skip to content

Apply assorted ruff/flake8-simplify rules (SIM) #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhamman merged 2 commits into from
Sep 26, 2024
Merged

Apply assorted ruff/flake8-simplify rules (SIM) #2259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd2f5ce
Apply ruff/flake8-simplify rule SIM103
DimitriPapadopoulos Sep 26, 2024
6b04cb0
Apply ruff/flake8-simplify rule SIM118
DimitriPapadopoulos Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply ruff/flake8-simplify rule SIM118 
SIM118 Use `key in dict` instead of `key in dict.keys()`
  • Loading branch information
@DimitriPapadopoulos
DimitriPapadopoulos committed Sep 26, 2024
commit 6b04cb034012b6e3eafa045424104bf1cbcee95e
4 changes: 2 additions & 2 deletions src/zarr/testing/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ async def test_list_prefix(self, store: S) -> None:
for prefix in prefixes:
observed = tuple(sorted(await _collect_aiterator(store.list_prefix(prefix))))
expected: tuple[str, ...] = ()
for key in store_dict.keys():
for key in store_dict:
if key.startswith(prefix):
expected += (key.removeprefix(prefix),)
expected = tuple(sorted(expected))
Expand All @@ -245,7 +245,7 @@ async def test_list_dir(self, store: S) -> None:
await store._set_many(store_dict.items())

keys_observed = await _collect_aiterator(store.list_dir(root))
keys_expected = {k.removeprefix(root + "/").split("/")[0] for k in store_dict.keys()}
keys_expected = {k.removeprefix(root + "/").split("/")[0] for k in store_dict}

assert sorted(keys_observed) == sorted(keys_expected)

Expand Down