Skip to content

Apply assorted ruff/Pylint rules (PLR) #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhamman merged 4 commits into from
Nov 5, 2024
Merged

Apply assorted ruff/Pylint rules (PLR) #2371

jhamman merged 4 commits into from
Nov 5, 2024

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 15, 2024 •
edited
Loading

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos
Apply ruff/Pylint rule PLR1711
deb4f39 
PLR1711 Useless `return` statement at end of function
@DimitriPapadopoulos
Apply ruff/Pylint rule PLR2044
d563577 
PLR2044 Line with empty comment
@DimitriPapadopoulos
Apply ruff/Pylint rule PLR6104
a1d08de 
PLR6104 Use `+=`, `*=`, `/=` to perform an augmented assignment directly
@jhamman jhamman merged commit f092351 into zarr-developers:main Nov 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhamman jhamman jhamman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitriPapadopoulos @jhamman