Skip to content

Error on invalid store mode #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstansby merged 4 commits into from
May 21, 2025
Merged

Error on invalid store mode #3068

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e2ffaa
Error on invalid store mode
dstansby May 18, 2025
f29b0da
Fix tests
dstansby May 18, 2025
2f93d79
Add release note
dstansby May 18, 2025
2f9dc01
Fix test
dstansby May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test
  • Loading branch information
@dstansby
dstansby committed May 21, 2025
commit 2f9dc01187db97c471f705c431e752200e32f8bf
2 changes: 1 addition & 1 deletion tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1285,7 +1285,7 @@ def test_no_overwrite_open(tmp_path: Path, open_func: Callable, mode: str) -> No
existing_fpath = add_empty_file(tmp_path)

assert existing_fpath.exists()
with contextlib.suppress(FileExistsError, FileNotFoundError):
with contextlib.suppress(FileExistsError, FileNotFoundError, ValueError):
open_func(store=store, mode=mode)
if mode == "w":
assert not existing_fpath.exists()
Expand Down
Loading