Skip to content

Conversation

@sea212
Copy link
Contributor

@sea212 sea212 commented Aug 20, 2023

What does it do?

Updates all substrate related dependencies to v0.9.38. Also updates all other dependencies to adequate versions.

Dependencies
Cumulus: https://github.com/paritytech/cumulus/tree/polkadot-v0.9.38
Moonbeam: https://github.com/PureStake/moonbeam/tree/v0.31.1
Nimbus: https://github.com/PureStake/nimbus/tree/moonbeam-polkadot-v0.9.38
ORML: https://github.com/open-web3-stack/open-runtime-module-library/tree/polkadot-v0.9.38
Polkadot: https://github.com/paritytech/polkadot/tree/release-v0.9.38
Substrate: https://github.com/paritytech/substrate/tree/polkadot-v0.9.38

Changes
Cumulus: paritytech/cumulus@polkadot-v0.9.37...polkadot-v0.9.38
Moonbeam: moonbeam-foundation/moonbeam@v0.30.3...v0.31.1
Nimbus: moonbeam-foundation/nimbus@moonbeam-polkadot-v0.9.37...moonbeam-polkadot-v0.9.38
ORML: open-web3-stack/open-runtime-module-library@polkadot-v0.9.37...polkadot-v0.9.38
Polkadot: paritytech/polkadot@release-v0.9.37...release-v0.9.38
Substrate: paritytech/substrate@polkadot-v0.9.37...polkadot-v0.9.38
Substrate-Parachain: https://github.com/substrate-developer-hub/substrate-parachain-template/compare/polkadot-v0.9.37...polkadot-v0.9.38

Migrations

parachain:

  • dmp_queue::migrations::migrate_to_v3 -> automatically triggered by pallet's on_runtime_upgrade hook
  • xcmp_queue::migrations::migrate_to_v3 -> automatically triggered by pallet's on_runtime_upgrade hook
  • pallet_xcm::migrations::MigrateToV1 -> Manually triggered
  • asset_registry::migrations::Migration -> Manually triggered
  • unknown_tokens::migrations::Migration -> Manually triggered

standalone:

  • pallet_grandpa::migrations::CleanupSetIdSessionMap -> Manually triggered

What important points should reviewers know?

  • XCM was updated to v3, which changes the API a bit

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Aug 20, 2023
@sea212 sea212 added this to the v0.4.0 milestone Aug 20, 2023
@sea212 sea212 self-assigned this Aug 20, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on and removed s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews labels Aug 23, 2023
Also format benchmark script and moves header file into HEADER_GPL3.
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 24, 2023
@sea212 sea212 requested a review from Chralt98 August 24, 2023 19:35
@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Aug 24, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on and removed s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews labels Aug 24, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews s:in-progress The pull requests is currently being worked on and removed s:in-progress The pull requests is currently being worked on s:review-needed The pull request requires reviews labels Aug 25, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 25, 2023
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the CI goes through without errors (with the new rustc version), I am fine with that.

Copy link
Contributor

@yornaath yornaath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for styx

@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 25, 2023
@sea212 sea212 merged commit 30c7414 into main Aug 25, 2023
@sea212 sea212 deleted the sea212-update-dependencies branch August 25, 2023 10:59
@sea212 sea212 mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:accepted This pull request is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants