Skip to content

Conversation

@sea212
Copy link
Contributor

@sea212 sea212 commented Feb 25, 2022

closes #397

In response to paritytech/substrate#9165

PalletVersion is replaced by StorageVersion. This PR adds StorageVersion to the storage of each of our pallets and initializes it with zero.
We could use paritytech/substrate#9165 (comment) to migrate our major number of the previous PalletVersion, but this would result in no changes, since the major number was zero in every case and the default value of the StorageVersion (u16) is zero as well (the storage is not initialized, hence the default value is used). Consequently, we can just skip that migration.

@sea212 sea212 added the s:in-progress The pull requests is currently being worked on label Feb 25, 2022
@sea212 sea212 self-assigned this Feb 25, 2022
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Feb 25, 2022
@sea212 sea212 requested a review from maltekliemann February 25, 2022 20:08
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Mar 3, 2022
@sea212 sea212 merged commit 694a221 into main Mar 3, 2022
@sea212 sea212 deleted the sea212-introduce-storage-version branch March 3, 2022 18:31
@sea212 sea212 added this to the v0.3.0 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:accepted This pull request is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pallets] Use StorageVersion instead of PalletVersion

3 participants