Remove report_todo from rustfmt config
#874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltekliemann
added
p:low
sea212
approved these changes
Dec 9, 2022
Contributor
sea212
left a comment
sea212
left a comment
There was a problem hiding this comment.
Finally no more report_todo spam during compilation. Now the structure of todo comments is not enforced anymore, correct? Is there no alternative, i.e. do we have to keep order now by convention?
Contributor
Author
There doesn't seem to be an alternative: rust-lang/rustfmt#5357. I've added checking for unnumbered TODOs to the checklist for reviews: #895. |
maltekliemann
added
s:accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.