Open
Conversation
Collaborator
Personally I like the idea of always using
For reference OoT puts it in |
hensldm
reviewed
Dec 11, 2025
hensldm
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the jp version of CIC6105.c
I matched this file (among a few others) a few months ago while testing the multiversion support.
There are a few open questions:
>= VERSION/>/</<=?cic6105TextStart. Where do we want to put those externed symbols?CIC6105.c: It is only referenced here, but it goes a bit against our conventions to put externs in a .c file.CIC6105.h: I guess could be fine?ucode.h: A libultra header with other rsp ucode syms. The main disadvantage I see is polluting libultra headers with game specific syms. (But I touched thembi.hfile 😅 )