This repository was archived by the owner on May 16, 2018. It is now read-only.
Zend_Oauth_Client: Consider multipart/form-data #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chmielot |
- Remove comment that states that a query string is returned - Change return type to array - Remove unnecessary code that created the query string which is not used again. - Add code to not include POST parameters when encoding is multipart/form-data - Add tests for both encodings and POST parameters The test uses a dummy class which extends Zend_Oauth_Client. This dummy class allows to call _getSignableParametersAsQueryString() directly. The reason for this is the following: This protected function is used in prepareOauth() only, which sets the request header 'Authorization'. This request header can be read via getHeader() but the parameters are already encoded and the encoded string changes with every call. It is not possible to determine the results of the _getSignableParametersAsQueryString() method by checking the headers. That's why I needed this stub.
|
@froschdesign |
|
ping @ezimuel |
|
Are there any problems with the fix? @froschdesign |
ezimuel
added a commit
that referenced
this pull request
Aug 20, 2014
Zend_Oauth_Client: Consider multipart/form-data
|
@chmielot Thanks for the PR and sorry for the delay of the merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters being sent that are not the oauth_* named parameters do not become part of the OAuth signature base string when the HTTP method being used is POST but the post body is not of the "Content-Type: x-www-form-urlencoded" variety.
Consider multipart/form-data encoding when retrieving parameters to encode:
is not used.
multipart/form-data
Problem popped up when I tried to send images to the twitter API. The encoding has to be multipart/form-data and the API didn't validate my credentials because they were simply wrong for that case.