Skip to content
This repository was archived by the owner on May 16, 2018. It is now read-only.

Conversation

@fetus-hina
Copy link
Contributor

This is a backported pull request. ZF2's PR is: zendframework/zendframework#4636

When validating host name like "xn--eckwd4c7cu47r2wf.jp", punycode decoder fails.

In typically case of Japanese(Maybe also Chinese and Korean) domain name, it hasn't ASCII characters. Then, encoded string has not hyphen after "xn--". In this case, current code reports decode error.

@fetus-hina
Copy link
Contributor Author

Sorry, I'll sign CLA and email this night(GMT+9:00) or next week.

@froschdesign
Copy link
Member

@fetus-hina
Please send also a copy to @weierophinney.

@froschdesign froschdesign added this to the 1.12.8 milestone Jul 11, 2014
@fetus-hina
Copy link
Contributor Author

I've sent CLA via email (cc'ed to @weierophinney's mailbox)

@froschdesign froschdesign self-assigned this Jul 16, 2014
froschdesign added a commit that referenced this pull request Jul 16, 2014
Validate_Hostname: Punycode decoding fails if encoded string has not hyphen
@froschdesign froschdesign merged commit fabc5af into zendframework:master Jul 16, 2014
@fetus-hina fetus-hina deleted the zf2-4636 branch July 18, 2014 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants