This repository was archived by the owner on May 16, 2018. It is now read-only.
Cast int and float to string when creating headers #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the ZF2015-04 patch, we were no longer allowing non-string, non-stringable objects as header values. This broke a number of other classes, however, which required integer and/or float values (e.g., to set a Content-Length header). This patch casts those types to strings before attempting to set them as header values.
There was a problem hiding this comment.
s/is_string/is_scalar/ could be enough
There was a problem hiding this comment.
As noted in IRC, the only other scalar types we can safely cast to string are floats and integers. Booleans should not be cast.
Man unit tests sufferred from the same issues as the Zend_Http_* tests, in that the canned responses had incorrect line endings in them, making them fail the new logic implemented to protect against message splitting. These have now all been updated.
|
@weierophinney |
froschdesign
added a commit
that referenced
this pull request
May 20, 2015
Cast int and float to string when creating headers
This was referenced May 20, 2015
Hahahahahahahaha! I've pinged @gianarb to look into the CLA webhook. :) Thanks for merging, @froschdesign - I'll start the release process. |
👍 |
|
Sorry :D :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ZF2015-04 patch in 1.12.12, we were no longer allowing non-string, non-stringable objects as header values. This broke a number of other classes, however, which required integer and/or float values (e.g., to set a Content-Length header). This patch casts those types to strings before attempting to set them as header values.