This repository was archived by the owner on May 16, 2018. It is now read-only.
Add ß (Latin small letter sharp s) to .de domain IDNA check #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ß was introduced in the [Unicode® Technical Standard #46](http://unicode.org/reports/tr46/#Deviations) standard. According to [denic.de](http://www.denic.de/en/domains/internationalized-domain-names/idn-list.html) this is a valid character. In the IDNA2003 standard the ß character is not included. This result in a false positive check. IMHO the IDNA2003 will be replaced soon with IDNA2008 and this is a minor side effect.
|
Should I also add an test case for this new behaviour? |
froschdesign
added a commit
that referenced
this pull request
Sep 1, 2015
Add ß (Latin small letter sharp s) to .de domain IDNA check
froschdesign
added a commit
that referenced
this pull request
Sep 1, 2015
|
@froschdesign If this has to be fixed in https://github.com/zendframework/zend-validator as well. How do I go forward. Perform an additional PR? Or is this coordinated by the ZF team? |
dsikkema-magento
pushed a commit
to magento/zf1
that referenced
this pull request
Sep 30, 2015
Zend Framework 1.12.16 - [504: Cannot parse huge documents in Zend&zendframework#95;Dom&zendframework#95;Query](zendframework#504) - [599: Wrong return type in DocBlock of Zend&zendframework#95;Console&zendframework#95;Getopt::getOption()](zendframework#599) - [600: Undefined property $config in Zend&zendframework#95;Http&zendframework#95;Client&zendframework#95;Adapter&zendframework#95;Curl](zendframework#600) - [604: add doccomments to Zend&zendframework#95;Log covering its magic methods](zendframework#604) - [606: Fix typo in Zend&zendframework#95;Cache-Backends documentation.](zendframework#606) - [610: Add ß (Latin small letter sharp s) to .de domain IDNA check](zendframework#610) - [612: Zend&zendframework#95;Validate&zendframework#95;Hostname does not validate NTP hostnames starting with '0' character](zendframework#612) SECURITY UPDATES ---------------- - **ZF2015-07**: A number of components, including `Zend_Cloud`, `Zend_Search_Lucene`, and `Zend_Service_WindowsAzure` were creating directories with a liberal umask that could lead to local arbitrary code execution and/or local privilege escalation. This release contains a patch that ensures the directories are created using permissions of 0775 and files using 0664 (essentially umask 0002). - **ZF2015-08**: ZF2014-06 uncovered an issue in the sqlsrv adapter provided by the framework whereby null bytes were not filtered correctly when generating SQL. A reporter discovered the same vulnerability is present in our PDO implementation when used with pdo_dblib, and could potentially be applied to other PDO adapters. This release contains a patch to properly escape null bytes used in SQL queries across all PDO adapters shipped with the framework. Conflicts: README.md
dgiotas
pushed a commit
to tripsta/zf1
that referenced
this pull request
Jun 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ß was introduced in the Unicode® Technical Standard #46 standard. According to denic.de this is a valid character.
In the IDNA2003 standard the ß character is not included. This result in a false positive check. IMHO the IDNA2003 will be replaced soon with IDNA2008 and this is a minor side effect.