Update ODBC connection validation for PHP 8.4 compatibility #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanseiden, thanks for merging this pull request. Are there any plans to release a new version? |
|
@jonkerw85 And thanks for your code contribution! Yes, we should make a new release soon. Thanks for pointing that out. |
|
@jonkerw85 New release 1.9.5 has been tagged that includes this PR. https://github.com/zendtech/IbmiToolkit/releases/tag/1.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Updated validation to handle the
Odbc\ConnectionandOdbc\Resultreturn types introduced in PHP 8.4. For PHP 8.4 and above, checks are now made forOdbc\Connection(fromodbc_connect()) andOdbc\Result(fromodbc_exec()). Retained support for PHP 8.3 and earlier, which use resource-based return types.Why This Change:
Ensures proper handling of ODBC connections and executions across PHP versions prior to 8.4, as well as 8.4 and above.
Testing:
Verified functionality on PHP 8.3 and 8.4 locally with successful results. The changes were tested primarily in the
connect()function inOdbcsupp.phpand the__constructmethod inToolkit.php. Did not test theexecuteQuery()anddisconnect()functions inOdbcsupp.php, as they are not used in my projects.