Merged
Conversation
jrushlow
commented
Feb 17, 2024
Contributor
Author
|
Not sure if ya'll use any sort of |
Member
|
Hi @jrushlow sorry to have been quite on this lately. Because we only use phpunit could rebase your PR, please? |
jrushlow
force-pushed
the
feature/phpunit-attributes
branch
from
e5ab9f5 to
79a6f97
Compare
Contributor
Author
|
@nikophil rebase done don't think the ci failure is related.. looks like a |
Member
|
absolutely, I'll fix this today |
Member
|
thanks @jrushlow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in PHPUnit 11 - the use of metadata in doc-comments is hard deprecated. Results in tests passing as expected but PHPUnit deprecation warnings everywhere...