Skip to content

use variable already set for URL and remove whitespace. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2014
Merged

use variable already set for URL and remove whitespace. #20

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
048e5df
use variable already set for URL
DanielOchoa Jun 25, 2014
66291e8
Changed zepto ajax to javascript xmlhttprequest and moved success and…
DanielOchoa Jun 25, 2014
356f4e1
make current path a MeteorRider property so we can use it on the onSu…
DanielOchoa Jun 25, 2014
bc07b30
use native javascript to call events.
DanielOchoa Jun 26, 2014
4817f8c
remove todo comment
DanielOchoa Jun 26, 2014
178bcb4
fix meteorUrl not being defined when object MeteorRider is defined
DanielOchoa Jun 27, 2014
b013189
meteorUrl can now be referenced inside the onSuccess callback
DanielOchoa Jun 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix meteorUrl not being defined when object MeteorRider is defined
  • Loading branch information
@DanielOchoa
DanielOchoa committed Jun 27, 2014
commit 178bcb46cdb4feed9f31664bdf5983c1990636ec
15 changes: 7 additions & 8 deletions www/js/meteor-rider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ var MeteorRider = {

init: function(currentPath) {

this.meteorUrl = __MeteorRiderConfig__.meteorUrl;
this.currentPath = currentPath;
var meteorUrl = __MeteorRiderConfig__.meteorUrl;

if (! (this.meteorUrl.length > 0)) {
if (! (meteorUrl.length > 0)) {
console.error('MeteorRider: error: unable to determine config.meteorUrl');
return false;
}

// non zepto/jquery request
request = new XMLHttpRequest();
request.open('GET', this.meteorUrl, true);
request.open('GET', meteorUrl, true);
request.onload = this.onSuccess;
request.onerror = this.onError;
request.send();
Expand All @@ -52,14 +52,14 @@ var MeteorRider = {

onSuccess: function () {
if (request.status >= 200 && request.status < 400) {

var meteorUrl = __MeteorRiderConfig__.meteorUrl;
var data = request.responseText;

console.log("MeteorRider success");
console.log(data);
// update URLs to include domain prefix
data = data.replace(/(href|src|manifest)\=\"\//gm, '$1="' + this.meteorUrl + '/');
console.log(this.meteorUrl);
data = data.replace(/(href|src|manifest)\=\"\//gm, '$1="' + meteorUrl + '/');
console.log(meteorUrl);
console.log(data);

// set 'currentPath' to empty string if not passed
Expand All @@ -68,7 +68,7 @@ var MeteorRider = {
// and other packages that depend on window.location work correctly
if (typeof window.history.replaceState === 'function') {
// window.history.replaceState() not supported in all clients
window.history.replaceState({}, "", this.meteorUrl + this.currentPath);
window.history.replaceState({}, "", meteorUrl + this.currentPath);
} else {
// TODO: should we do window.history.add() or something?
}
Expand All @@ -81,7 +81,6 @@ var MeteorRider = {
document.open();
document.write(data);
document.close();

// trigger the "loaded" events (it'd be nice to do this AFTER JS has loaded
function triggerEvent (eventName) {
var event = document.createEvent('Event');
Expand Down