This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Ensure all factories are compatible with both major versions of zend-servicemanager #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…servicemanager - Removed `FactoryInterface` implmentation at class level; since each now implements an `__invoke()` method, they are each compatible with both major versions. - Updated all factories to only accept the arguments they use (as we are not implementing an interface). - Ensured all factories that pull the config service use `config` vs `Config` for forwards compatibility.
|
FIxes #46 |
weierophinney
added a commit
that referenced
this pull request
Jul 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FactoryInterfaceimplmentation at class level; since each now implements an__invoke()method, they are each compatible with both major versions.configvsConfigfor forwards compatibility.