Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure SwaggerViewStrategy tests correctly against v2 and v3 eventman…
…ager
  • Loading branch information
weierophinney committed Jul 14, 2016
commit c028eb735bdc981ce1d7cc564de09e9652822d51
10 changes: 6 additions & 4 deletions src/SwaggerViewStrategy.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@

namespace ZF\Apigility\Documentation\Swagger;

use Zend\EventManager\AbstractListenerAggregate;
use Zend\EventManager\EventManagerInterface;
use Zend\EventManager\ListenerAggregateInterface;
use Zend\EventManager\ListenerAggregateTrait;
use Zend\View\Renderer\JsonRenderer;
use Zend\View\ViewEvent;

class SwaggerViewStrategy extends AbstractListenerAggregate
class SwaggerViewStrategy implements ListenerAggregateInterface
{
use ListenerAggregateTrait;

/**
* @var ViewModel
*/
Expand All @@ -32,8 +35,7 @@ public function __construct(JsonRenderer $renderer)
}

/**
* @param EventManagerInterface $events
* @param int $priority
* {@inheritDoc}
*/
public function attach(EventManagerInterface $events, $priority = 200)
{
Expand Down
25 changes: 15 additions & 10 deletions test/SwaggerViewStrategyTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

use PHPUnit_Framework_TestCase as TestCase;
use Zend\EventManager\EventManager;
use Zend\EventManager\Test\EventListenerIntrospectionTrait;
use Zend\Http\Response as HttpResponse;
use Zend\Stdlib\Response as StdlibResponse;
use Zend\View\Renderer\JsonRenderer;
Expand All @@ -17,6 +18,8 @@

class SwaggerViewStrategyTest extends TestCase
{
use EventListenerIntrospectionTrait;

public function setUp()
{
$this->events = new EventManager();
Expand All @@ -27,17 +30,19 @@ public function setUp()

public function testStrategyAttachesToViewEventsAtPriority200()
{
$listeners = $this->events->getListeners(ViewEvent::EVENT_RENDERER);
$this->assertEquals(1, count($listeners));
$listener = $listeners->top();
$this->assertEquals([$this->strategy, 'selectRenderer'], $listener->getCallback());
$this->assertEquals(200, $listener->getMetadatum('priority'));
$this->assertListenerAtPriority(
[$this->strategy, 'selectRenderer'],
200,
ViewEvent::EVENT_RENDERER,
$this->events
);

$listeners = $this->events->getListeners(ViewEvent::EVENT_RESPONSE);
$this->assertEquals(1, count($listeners));
$listener = $listeners->top();
$this->assertEquals([$this->strategy, 'injectResponse'], $listener->getCallback());
$this->assertEquals(200, $listener->getMetadatum('priority'));
$this->assertListenerAtPriority(
[$this->strategy, 'injectResponse'],
200,
ViewEvent::EVENT_RESPONSE,
$this->events
);
}

public function testSelectRendererReturnsJsonRendererWhenSwaggerViewModelIsPresentInEvent()
Expand Down