This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Fix SwaggerUiControllerFactory #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weierophinney Could this please be committed ... |
|
How long we have to wait for this little change? |
|
+1 waiting for merge PR |
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Fix SwaggerUiControllerFactory
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
|
Thanks, @weckx; issuing the 1.2.1 release now with the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem reported in issue #25 where the factor stopped instantiating the controller due to a wrong variable name. I've also added a unit test to detect problems with the factory.