This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Follow-up to #103 #105
Closed
Follow-up to #103 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $method | ||
| * @param string $event | ||
| */ | ||
| public function testErrorInMethodReturnsApiProblem($method, $event, $argv) |
Member
There was a problem hiding this comment.
This test should be conditional on whether or not PHP 7 is being used. You can do that with an annotation: @requires PHP 7.
This was referenced Oct 11, 2016
Merged
Member
Author
|
Tests are failing because ping @weierophinney |
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.