Skip to content

Add fast path for byte arrays and slices #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikskuh merged 2 commits into from
Jun 20, 2022
Merged

Add fast path for byte arrays and slices #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899b78b
Add fast path for byte arrays and slices
fabioarnold Jun 17, 2022
8c1da6e
Use `readNoEof` instead of `readAll`
fabioarnold Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions s2s.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,25 @@ fn serializeRecursive(stream: anytype, comptime T: type, value: T) @TypeOf(strea
.One => try serializeRecursive(stream, ptr.child, value.*),
.Slice => {
try stream.writeIntLittle(u64, value.len);
for (value) |item| {
try serializeRecursive(stream, ptr.child, item);
if (ptr.child == u8) {
try stream.writeAll(value);
} else {
for (value) |item| {
try serializeRecursive(stream, ptr.child, item);
}
}
},
.C => unreachable,
.Many => unreachable,
}
},
.Array => |arr| {
for (value) |item| {
try serializeRecursive(stream, arr.child, item);
if (arr.child == u8) {
try stream.writeAll(&value);
} else {
for (value) |item| {
try serializeRecursive(stream, arr.child, item);
}
}
if (arr.sentinel != null) @compileError("Sentinels are not supported yet!");
},
Expand Down Expand Up @@ -221,8 +229,12 @@ fn recursiveDeserialize(stream: anytype, comptime T: type, allocator: ?std.mem.A
const slice = try allocator.?.alloc(ptr.child, length);
errdefer allocator.?.free(slice);

for (slice) |*item| {
try recursiveDeserialize(stream, ptr.child, allocator, item);
if (ptr.child == u8) {
_ = try stream.readAll(slice);
} else {
for (slice) |*item| {
try recursiveDeserialize(stream, ptr.child, allocator, item);
}
}

target.* = slice;
Expand All @@ -232,8 +244,12 @@ fn recursiveDeserialize(stream: anytype, comptime T: type, allocator: ?std.mem.A
}
},
.Array => |arr| {
for (target.*) |*item| {
try recursiveDeserialize(stream, arr.child, allocator, item);
if (arr.child == u8) {
_ = try stream.readAll(target);
} else {
for (target.*) |*item| {
try recursiveDeserialize(stream, arr.child, allocator, item);
}
}
},
.Struct => |str| {
Expand Down