Skip to content

comptime is needed for 'runtime' calls #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikskuh merged 2 commits into from
May 6, 2023
Merged

comptime is needed for 'runtime' calls #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578baaa
comptime is needed for 'runtime' calls
Deecellar May 6, 2023
bc6247c
remove guesswork
Deecellar May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions s2s.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ fn serializeRecursive(stream: anytype, comptime T: type, value: T) @TypeOf(strea
.ErrorSet => {
// Error unions are serialized by "index of sorted name", so we
// hash all names in the right order
const names = getSortedErrorNames(T);
const names = comptime getSortedErrorNames(T);

const index = for (names, 0..) |name, i| {
if (std.mem.eql(u8, name, @errorName(value)))
Expand Down Expand Up @@ -485,13 +485,13 @@ fn getSortedErrorNames(comptime T: type) []const []const u8 {
sorted_names[i] = err.name;
}

std.sort.sort([]const u8, &sorted_names, {}, struct {
std.sort.sort([]const u8, &sorted_names, {}, struct {
fn order(ctx: void, lhs: []const u8, rhs: []const u8) bool {
_ = ctx;
return (std.mem.order(u8, lhs, rhs) == .lt);
}
}.order);
return &sorted_names;
return &sorted_names;
}
}

Expand Down Expand Up @@ -580,7 +580,7 @@ fn computeTypeHashInternal(hasher: *TypeHashFn, comptime T: type) void {
// hash all names in the right order

hasher.update("error set");
const names = getSortedErrorNames(T);
const names = comptime getSortedErrorNames(T);
for (names) |name| {
hasher.update(name);
}
Expand Down