Custom log file placement #669
Open
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem necessary to split the configuration of log file into log path and log name, but cleaner to just combine them.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mottosen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the
log_utiluse the env vars for configuring log file placement, and it seems to work as intended for me - I'm able to make the output fit with the experiment structure I'm looking for, by overwriting the defaults. The first commit follows the env vars onmaincurrently, and the second commit cleans up this a bit; seems unnecessary to split the logic intoFILE_PATHandFILE_NAME.