Skip to content

refactor readers to use type parameters and not concrete vtables #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

refactor readers to use type parameters and not concrete vtables #207

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
020a61a
add ZipEntry API in src/unstable/read.rs
cosmicexplorer Jul 2, 2024
3abac52
remove read_zipfile_from_stream()
cosmicexplorer Jul 16, 2024
b463f02
fix up some public methods to use new impls
cosmicexplorer Jul 16, 2024
f0faf24
remove the old ZipFile API entirely
cosmicexplorer Jul 16, 2024
bf63d19
remove a few more dyns
cosmicexplorer Jul 16, 2024
3960e34
make AesModeInfo pub(crate) to make its intention clear
cosmicexplorer Jul 16, 2024
27ba4d9
refactor streaming
cosmicexplorer Jul 16, 2024
9fee2c8
fmt and clippy
cosmicexplorer Jul 16, 2024
c360b15
make ArchiveEntry more publicly accessible
cosmicexplorer Jul 16, 2024
8c7cae1
allow(private_interfaces) -> allow(warnings)
cosmicexplorer Jul 16, 2024
fb37849
fix impl trait return
cosmicexplorer Jul 16, 2024
872bd35
fix private bounds on stable
cosmicexplorer Jul 16, 2024
fd11f28
remove now-dead code
cosmicexplorer Jul 16, 2024
a28a43d
fix for windows
cosmicexplorer Jul 16, 2024
423a263
Revert "remove now-dead code"
cosmicexplorer Jul 17, 2024
c83e9b6
Revert "remove the old ZipFile API entirely"
cosmicexplorer Jul 17, 2024
3259c5e
Revert "remove read_zipfile_from_stream()"
cosmicexplorer Jul 17, 2024
bbee45b
remove unused
cosmicexplorer Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unused
  • Loading branch information
@cosmicexplorer
cosmicexplorer committed Jul 17, 2024
commit bbee45bcbd218bf5a6819804113ffc87f66cf8f7
4 changes: 0 additions & 4 deletions src/crc32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ pub(crate) mod non_crypto {
Err("Invalid checksum")
}
}

pub fn into_inner(self) -> R {
self.inner
}
}

impl<R: Read> Read for Crc32Reader<R> {
Expand Down
2 changes: 1 addition & 1 deletion src/write.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use crate::types::{
ffi, AesModeInfo, AesVendorVersion, DateTime, ZipFileData, ZipLocalEntryBlock, ZipRawValues,
MIN_VERSION,
};
use crate::unstable::read::{find_entry_content_range, ArchiveEntry, ZipEntry};
use crate::unstable::read::find_entry_content_range;
use crate::write::ffi::S_IFLNK;
#[cfg(any(feature = "_deflate-any", feature = "bzip2", feature = "zstd",))]
use core::num::NonZeroU64;
Expand Down