-
Notifications
You must be signed in to change notification settings - Fork 87
fix: enable clamp_opt for ppmd and xz #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @danielrainer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a functional gap related to XZ compression. It ensures that a specific utility function, clamp_opt, is properly included in the build when the xz feature is enabled, thereby completing the necessary support for XZ compression within the system.
Highlights
- XZ Compression Support: The
clamp_optfunction, essential for handling compression levels, is now correctly enabled when only thexzfeature is active, resolving an issue wherexzcompression was not fully functional under this condition.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a build issue for the xz feature by including it in the cfg attribute for the clamp_opt function. However, a similar issue exists for the ppmd feature, which also relies on clamp_opt but has been omitted from the configuration. I've provided a suggestion to include the ppmd feature to ensure its functionality when enabled in isolation.
Make ppmd/xz compression work if only the respective feature is enabled.
ed33e67 to
bc197e1
Compare
Make ppmd/xz compression work if only the respective feature is enabled. Co-authored-by: Daniel Rainer <daniel.rainer@localhost>
Make ppmd/xz compression work if only the respective feature is enabled.