Skip to content

Conversation

@danielrainer
Copy link
Contributor

@danielrainer danielrainer commented Aug 29, 2025

Make ppmd/xz compression work if only the respective feature is enabled.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @danielrainer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a functional gap related to XZ compression. It ensures that a specific utility function, clamp_opt, is properly included in the build when the xz feature is enabled, thereby completing the necessary support for XZ compression within the system.

Highlights

  • XZ Compression Support: The clamp_opt function, essential for handling compression levels, is now correctly enabled when only the xz feature is active, resolving an issue where xz compression was not fully functional under this condition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a build issue for the xz feature by including it in the cfg attribute for the clamp_opt function. However, a similar issue exists for the ppmd feature, which also relies on clamp_opt but has been omitted from the configuration. I've provided a suggestion to include the ppmd feature to ensure its functionality when enabled in isolation.

Make ppmd/xz compression work if only the respective feature is enabled.
@danielrainer danielrainer changed the title fix: enable clamp_opt for xz fix: enable clamp_opt for ppmd and xz Aug 29, 2025
@Pr0methean Pr0methean enabled auto-merge August 30, 2025 17:24
@Pr0methean Pr0methean added this pull request to the merge queue Aug 30, 2025
Merged via the queue into zip-rs:master with commit 5373800 Aug 30, 2025
65 checks passed
@Pr0methean Pr0methean mentioned this pull request Aug 30, 2025
cosmicexplorer pushed a commit to cosmicexplorer/zip2 that referenced this pull request Sep 30, 2025
Make ppmd/xz compression work if only the respective feature is enabled.

Co-authored-by: Daniel Rainer <daniel.rainer@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants