-
Notifications
You must be signed in to change notification settings - Fork 95
chore: release v7.0.0 #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
β³ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion. Using Amazon Q Developer for GitHubAmazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation. Slash Commands
FeaturesAgentic Chat Code Review CustomizationYou can create project-specific rules for Amazon Q Developer to follow:
Example rule: FeedbackTo provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository. For more detailed information, visit the Amazon Q for GitHub documentation. Footnotes
|
Summary of ChangesHello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release of version "7.0.0" for the "zip" crate. This major version bump incorporates new features like "const DEFAULT" for "SimpleFileOptions" and improved large-file handling, alongside critical bug fixes. It also includes breaking changes by removing several feature flags, some of which were deprecated, to streamline the API. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a well-structured release PR that properly updates the version to 7.0.0 and includes comprehensive changelog entries. The changes follow the project's conventions and Conventional Commits format. The version bump and changelog additions are appropriate for a major release, and all formatting appears correct.
The PR is ready for merge once CI passes.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the v7.0.0 release by updating the version in Cargo.toml and adding a new entry to CHANGELOG.md. My review focuses on the completeness and clarity of the changelog. I've found that the list of breaking changes is incomplete and the structure could be improved for better readability. I've provided a suggestion to address this, ensuring all breaking changes are documented in a dedicated section as is crucial for a major version release.
| ## [7.0.0](https://github.com/zip-rs/zip2/compare/v6.0.0...v7.0.0) - 2025-12-05 | ||
|
|
||
| ### <!-- 0 -->π Features | ||
|
|
||
| - *(`SimpleFileOptions`)* const DEFAULT implementation ([#474](https://github.com/zip-rs/zip2/pull/474)) | ||
| - ZipWriter `set_auto_large_file()` method to enable large-file data descriptor when necessary ([#468](https://github.com/zip-rs/zip2/pull/468)) | ||
|
|
||
| ### <!-- 1 -->π Bug Fixes | ||
|
|
||
| - print previous error when failing to search another cde ([#460](https://github.com/zip-rs/zip2/pull/460)) | ||
| - cargo doc warnings ([#472](https://github.com/zip-rs/zip2/pull/472)) | ||
| - Write ZIP64 data descriptors when large_file option is true ([#467](https://github.com/zip-rs/zip2/pull/467)) | ||
| - Pin generic-array to an old version to work around https://github.com/RustCrypto/traits/issues/2036 until next RustCrypto & aes-crypto releases ([#458](https://github.com/zip-rs/zip2/pull/458)) | ||
|
|
||
| ### <!-- 7 -->βοΈ Miscellaneous Tasks | ||
|
|
||
| - Revert version bump so that release-plz will trigger | ||
| - expose more flate2 feature flags ([#476](https://github.com/zip-rs/zip2/pull/476)) | ||
| - Next release will be 7.0.0 | ||
| - release v6.0.0 ([#442](https://github.com/zip-rs/zip2/pull/442)) | ||
|
|
||
| ### Deps | ||
|
|
||
| - Bump lzma-rust2 to v0.15 ([#465](https://github.com/zip-rs/zip2/pull/465)) | ||
|
|
||
| ### <!-- 7 -->βοΈ Miscellaneous Tasks | ||
|
|
||
| - [**breaking**] Remove `lzma-static` and `xz-static` feature flags, which are deprecated synonyms of `lzma` and `xz`. (#405, #425) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog for this major release appears to be incomplete and could be better structured.
1. Incomplete Breaking Changes
The PR description, based on cargo-semver-checks, lists several removed features as breaking changes (getrandom, lzma-static, zeroize, xz-static, pbkdf2, sha1, hmac), but the changelog only mentions lzma-static and xz-static. It's crucial for a major release to document all breaking changes clearly for users.
2. Structure
There are two ### <!-- 7 -->βοΈ Miscellaneous Tasks sections, which is confusing. Also, breaking changes should ideally be in a dedicated ### β οΈ Breaking Changes or ### Removed section for better visibility, rather than under Miscellaneous Tasks.
I've suggested a revised structure below that addresses these points by adding a dedicated breaking changes section and consolidating the miscellaneous tasks.
## [7.0.0](https://github.com/zip-rs/zip2/compare/v6.0.0...v7.0.0) - 2025-12-05
### <!-- 9 -->β οΈ Breaking Changes
- Removed the following features: `getrandom`, `hmac`, `pbkdf2`, `sha1`, `zeroize`.
- Removed `lzma-static` and `xz-static` feature flags, which were deprecated synonyms of `lzma` and `xz`. ([#405](https://github.com/zip-rs/zip2/pull/405), [#425](https://github.com/zip-rs/zip2/pull/425))
### <!-- 0 -->π Features
- *(`SimpleFileOptions`)* const DEFAULT implementation ([#474](https://github.com/zip-rs/zip2/pull/474))
- ZipWriter `set_auto_large_file()` method to enable large-file data descriptor when necessary ([#468](https://github.com/zip-rs/zip2/pull/468))
### <!-- 1 -->π Bug Fixes
- print previous error when failing to search another cde ([#460](https://github.com/zip-rs/zip2/pull/460))
- cargo doc warnings ([#472](https://github.com/zip-rs/zip2/pull/472))
- Write ZIP64 data descriptors when large_file option is true ([#467](https://github.com/zip-rs/zip2/pull/467))
- Pin generic-array to an old version to work around https://github.com/RustCrypto/traits/issues/2036 until next RustCrypto & aes-crypto releases ([#458](https://github.com/zip-rs/zip2/pull/458))
### <!-- 7 -->βοΈ Miscellaneous Tasks
- Revert version bump so that release-plz will trigger
- expose more flate2 feature flags ([#476](https://github.com/zip-rs/zip2/pull/476))
- Next release will be 7.0.0
- release v6.0.0 ([#442](https://github.com/zip-rs/zip2/pull/442))
### Deps
- Bump lzma-rust2 to v0.15 ([#465](https://github.com/zip-rs/zip2/pull/465))
π€ New release
zip: 6.0.0 -> 7.0.0 (β API breaking changes)β
zipbreaking changesChangelog
This PR was generated with release-plz.