Skip to content

Conversation

@Pr0methean
Copy link
Member

πŸ€– New release

  • zip: 6.0.0 -> 7.0.0 (⚠ API breaking changes)

⚠ zip breaking changes

--- failure feature_missing: package feature removed or renamed ---

Description:
A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/feature_missing.ron

Failed in:
  feature getrandom in the package's Cargo.toml
  feature lzma-static in the package's Cargo.toml
  feature zeroize in the package's Cargo.toml
  feature xz-static in the package's Cargo.toml
  feature pbkdf2 in the package's Cargo.toml
  feature sha1 in the package's Cargo.toml
  feature hmac in the package's Cargo.toml
Changelog

7.0.0 - 2025-12-05

πŸš€ Features

  • (SimpleFileOptions) const DEFAULT implementation (#474)
  • ZipWriter set_auto_large_file() method to enable large-file data descriptor when necessary (#468)

πŸ› Bug Fixes

βš™οΈ Miscellaneous Tasks

  • Revert version bump so that release-plz will trigger
  • expose more flate2 feature flags (#476)
  • Next release will be 7.0.0
  • release v6.0.0 (#442)

Deps

  • Bump lzma-rust2 to v0.15 (#465)

βš™οΈ Miscellaneous Tasks


This PR was generated with release-plz.

@amazon-q-developer
Copy link
Contributor

⏳ Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command Description
/q <message> Chat with the agent to ask questions or request revisions
/q review Requests an Amazon Q powered code review
/q help Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

  1. Create a .amazonq/rules folder in your project root.
  2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
  3. Write detailed prompts in these files, such as coding standards or best practices.
  4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

  1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy. ↩

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the release of version "7.0.0" for the "zip" crate. This major version bump incorporates new features like "const DEFAULT" for "SimpleFileOptions" and improved large-file handling, alongside critical bug fixes. It also includes breaking changes by removing several feature flags, some of which were deprecated, to streamline the API.

Highlights

  • Major Version Release: This pull request introduces version "7.0.0" of the "zip" crate, marking a significant update with new features, bug fixes, and breaking changes.
  • API Breaking Changes: Several feature flags, including "getrandom", "lzma-static", "zeroize", "xz-static", "pbkdf2", "sha1", and "hmac", have been removed. Specifically, "lzma-static" and "xz-static" were deprecated synonyms.
  • New Features: New functionalities include a "const DEFAULT" implementation for "SimpleFileOptions" and a "set_auto_large_file()" method for "ZipWriter" to handle large-file data descriptors.
  • Bug Fixes and Dependencies: The release addresses several bugs, such as error reporting, cargo doc warnings, and correct ZIP64 data descriptor writing. It also pins "generic-array" to an older version as a workaround and bumps "lzma-rust2" to v0.15.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-structured release PR that properly updates the version to 7.0.0 and includes comprehensive changelog entries. The changes follow the project's conventions and Conventional Commits format. The version bump and changelog additions are appropriate for a major release, and all formatting appears correct.

The PR is ready for merge once CI passes.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v7.0.0 release by updating the version in Cargo.toml and adding a new entry to CHANGELOG.md. My review focuses on the completeness and clarity of the changelog. I've found that the list of breaking changes is incomplete and the structure could be improved for better readability. I've provided a suggestion to address this, ensuring all breaking changes are documented in a dedicated section as is crucial for a major version release.

Comment on lines +10 to 37
## [7.0.0](https://github.com/zip-rs/zip2/compare/v6.0.0...v7.0.0) - 2025-12-05

### <!-- 0 -->πŸš€ Features

- *(`SimpleFileOptions`)* const DEFAULT implementation ([#474](https://github.com/zip-rs/zip2/pull/474))
- ZipWriter `set_auto_large_file()` method to enable large-file data descriptor when necessary ([#468](https://github.com/zip-rs/zip2/pull/468))

### <!-- 1 -->πŸ› Bug Fixes

- print previous error when failing to search another cde ([#460](https://github.com/zip-rs/zip2/pull/460))
- cargo doc warnings ([#472](https://github.com/zip-rs/zip2/pull/472))
- Write ZIP64 data descriptors when large_file option is true ([#467](https://github.com/zip-rs/zip2/pull/467))
- Pin generic-array to an old version to work around https://github.com/RustCrypto/traits/issues/2036 until next RustCrypto & aes-crypto releases ([#458](https://github.com/zip-rs/zip2/pull/458))

### <!-- 7 -->βš™οΈ Miscellaneous Tasks

- Revert version bump so that release-plz will trigger
- expose more flate2 feature flags ([#476](https://github.com/zip-rs/zip2/pull/476))
- Next release will be 7.0.0
- release v6.0.0 ([#442](https://github.com/zip-rs/zip2/pull/442))

### Deps

- Bump lzma-rust2 to v0.15 ([#465](https://github.com/zip-rs/zip2/pull/465))

### <!-- 7 -->βš™οΈ Miscellaneous Tasks

- [**breaking**] Remove `lzma-static` and `xz-static` feature flags, which are deprecated synonyms of `lzma` and `xz`. (#405, #425)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The changelog for this major release appears to be incomplete and could be better structured.

1. Incomplete Breaking Changes

The PR description, based on cargo-semver-checks, lists several removed features as breaking changes (getrandom, lzma-static, zeroize, xz-static, pbkdf2, sha1, hmac), but the changelog only mentions lzma-static and xz-static. It's crucial for a major release to document all breaking changes clearly for users.

2. Structure

There are two ### <!-- 7 -->βš™οΈ Miscellaneous Tasks sections, which is confusing. Also, breaking changes should ideally be in a dedicated ### ⚠️ Breaking Changes or ### Removed section for better visibility, rather than under Miscellaneous Tasks.

I've suggested a revised structure below that addresses these points by adding a dedicated breaking changes section and consolidating the miscellaneous tasks.

## [7.0.0](https://github.com/zip-rs/zip2/compare/v6.0.0...v7.0.0) - 2025-12-05

### <!-- 9 -->⚠️ Breaking Changes

- Removed the following features: `getrandom`, `hmac`, `pbkdf2`, `sha1`, `zeroize`.
- Removed `lzma-static` and `xz-static` feature flags, which were deprecated synonyms of `lzma` and `xz`. ([#405](https://github.com/zip-rs/zip2/pull/405), [#425](https://github.com/zip-rs/zip2/pull/425))

### <!-- 0 -->πŸš€ Features

- *(`SimpleFileOptions`)* const DEFAULT implementation ([#474](https://github.com/zip-rs/zip2/pull/474))
- ZipWriter `set_auto_large_file()` method to enable large-file data descriptor when necessary ([#468](https://github.com/zip-rs/zip2/pull/468))

### <!-- 1 -->πŸ› Bug Fixes

- print previous error when failing to search another cde ([#460](https://github.com/zip-rs/zip2/pull/460))
- cargo doc warnings ([#472](https://github.com/zip-rs/zip2/pull/472))
- Write ZIP64 data descriptors when large_file option is true ([#467](https://github.com/zip-rs/zip2/pull/467))
- Pin generic-array to an old version to work around https://github.com/RustCrypto/traits/issues/2036 until next RustCrypto & aes-crypto releases ([#458](https://github.com/zip-rs/zip2/pull/458))

### <!-- 7 -->βš™οΈ Miscellaneous Tasks

- Revert version bump so that release-plz will trigger
- expose more flate2 feature flags ([#476](https://github.com/zip-rs/zip2/pull/476))
- Next release will be 7.0.0
- release v6.0.0 ([#442](https://github.com/zip-rs/zip2/pull/442))

### Deps

- Bump lzma-rust2 to v0.15 ([#465](https://github.com/zip-rs/zip2/pull/465))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants