Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
extra_params use Hash#deep_merge! instead of merge
This allows support for this use case:

```ruby
post '/post' do
  parameter :title, 'Title of post', scope: :post
  parameter :author_id, 'Integer of author', scope: :post

  let(:title) { 'My First Post' }
  let(:author_id) { '8' }

  example_request 'returns successful' do
    expect(response_body).to have_key(:id)
  end

  example_request 'fails with malformed id', post: {author_id: 'asdf' } do
    expect(response_body).to have_key(:errors)
  end
end
```

Before this change the params changes from `post: {title: 'My First Post', author_id: 'asdf'}` to `post: {author_id: 'asdf'}`. `Hash#deep_merge!` resolves this.
  • Loading branch information
jsmestad committed Dec 5, 2014
commit e0ae445b68adeecbdb3c69a742647bdf12a8bd37
2 changes: 1 addition & 1 deletion lib/rspec_api_documentation/dsl/endpoint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def params
parameters = example.metadata.fetch(:parameters, {}).inject({}) do |hash, param|
set_param(hash, param)
end
parameters.merge!(extra_params)
parameters.deep_merge!(extra_params)
parameters
end

Expand Down