Remove unneeded default values #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadityataparia
force-pushed
the
aadi/remove_defaults
branch
3 times, most recently
from
b462191 to
327a110
Compare
aadityataparia
force-pushed
the
aadi/remove_defaults
branch
from
327a110 to
06fba57
Compare
|
@oestrich Please 🙏 |
|
@aadityataparia Can you update the PR to fix the merge conflict? I suspect it's just taking whatever master has now, but I want to have you check that. |
|
@oestrich Done ✅ |
aadityataparia
force-pushed
the
aadi/remove_defaults
branch
from
be51d4e to
50c4330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #419
Removes default values for not
requiredfields.