Try to restore CI #461
Merged
Try to restore CI #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Untrack Gemfile.lock - Move `inch` gem from Gemfile to development dependency in gemspec Details: https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
|
Yass! 🎉 |
|
@oestrich let's merge this! And maybe give op commit? |
|
@bf4 @davidstosik merging this.. sorry for the long delay. Open to thoughts around the future of project maintenance, see: #478 |
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick attempt at getting green CI, after short conversation with @bf4 here: #458 (comment)
Cleanup Gemfile stuff
inchgem from Gemfile to development dependency in gemspecDetails:
https://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Freeze development dependencies
Now Gemfile.lock is gone, the only thing governing which version of a gem to use in CI is the gemspec. First step was to lock the version of enough gems enough that
bundle exec rakepasses.Next steps
Update dependencies
From here, anyone could look a the dependencies one by one and do the following work:
For indirect dependencies, once their version constraint has been cleared, they should be removed from the gemspec file.
Depending on the versions of Ruby
rspec_api_documentationwants to support, there might be more work (some gems drop support for older versions of Ruby, which means that depending on the local version of Ruby, one or another version of a gem could be needed).Test in newer versions of Ruby
Then someone might want to introduce newer versions of Ruby on CI (in .travis.yml).