Skip to content

Conversation

zkydrx
Copy link
Owner

@zkydrx zkydrx commented Oct 28, 2018

  • Fixed wrong else condition

  • Simplified creating Set of numbers

  • Deleted unused imports

  • Replaced 'for' loop with 'foreach' one

  • Replaced explicit type with diamond

  • Removed unnecesary brackets from lambda

  • Removed unnecesary contains check before adding element to Set

  • Fixed typo and changed non-english constant names

Pull request title

  • Clearly and concisely describes what it does
  • Refer to the issue that it solves, if available

Pull request description

  • Describes the main changes that come with the pull request
  • Any relevant additional information is provided

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

* Fixed wrong else condition

* Simplified creating Set of numbers

* Deleted unused imports

* Replaced 'for' loop with 'foreach' one

* Replaced explicit type with diamond

* Removed unnecesary brackets from lambda

* Removed unnecesary contains check before adding element to Set

* Fixed typo and changed non-english constant names
@zkydrx zkydrx merged commit 340f64d into zkydrx:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants