Skip to content

Implement batch runner for postgresql. #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Implement batch runner for postgresql. #193

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22385b1
Implement batch runner for postgresql.
raol Dec 9, 2015
8601958
Remove detecting outside transaction.
raol Mar 4, 2016
f43974e
Put schema and table name in quotes
raol Mar 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove detecting outside transaction. 
- Previously we detected outside transactions using System.Transaction, but recently
  we overcame the issue using specific configuration of the PgSql devart provider.
  It's redundant code now and should be removed to make everything consistent
  with the rest of the code.
  • Loading branch information
@raol
raol committed Mar 4, 2016
commit 8601958c39e2d79133c9f7befed0ed4c9f81f6f0
8 changes: 2 additions & 6 deletions Source/EntityFramework.Extended/Batch/PgSqlBatchRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,12 @@ private int InternalDelete<TEntity>(ObjectContext objectContext, EntityMap entit
ownConnection = true;
}

// When in TransactionScope PostgreSQL does not allow to create nested transaction
if (deleteTransaction == null && System.Transactions.Transaction.Current == null)
if (deleteTransaction == null)
{
deleteTransaction = deleteConnection.BeginTransaction();
ownTransaction = true;
}


deleteCommand = deleteConnection.CreateCommand();
deleteCommand.Transaction = deleteTransaction;
if (objectContext.CommandTimeout.HasValue)
Expand Down Expand Up @@ -213,9 +211,7 @@ private int InternalUpdate<TEntity>(ObjectContext objectContext, EntityMap entit
ownConnection = true;
}

// use existing transaction or create new
// When in TransactionScope PostgreSQL does not allow to create nested transaction
if (updateTransaction == null && System.Transactions.Transaction.Current != null)
if (updateTransaction == null)
{
updateTransaction = updateConnection.BeginTransaction();
ownTransaction = true;
Expand Down
1 change: 0 additions & 1 deletion Source/EntityFramework.Extended/EntityFramework.Extended.net45.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
<Reference Include="System.Core" />
<Reference Include="System.Runtime.Caching" />
<Reference Include="System.Runtime.Serialization" />
<Reference Include="System.Transactions" />
<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="Microsoft.CSharp" />
Expand Down