Skip to content

ExpressionParser: add 2nd ctor with an extra non-optional parameter #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefH merged 1 commit into from
Jan 24, 2025
Merged

ExpressionParser: add 2nd ctor with an extra non-optional parameter #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,18 @@
/// </summary>
public string LastLambdaItName { get; private set; } = KeywordsHelper.KEYWORD_IT;

/// <summary>
/// Initializes a new instance of the <see cref="ExpressionParser"/> class.
/// </summary>
/// <param name="parameters">The parameters.</param>
/// <param name="expression">The expression.</param>
/// <param name="values">The values.</param>
/// <param name="parsingConfig">The parsing configuration.</param>
public ExpressionParser(ParameterExpression[]? parameters, string expression, object?[]? values, ParsingConfig? parsingConfig) :
this(parameters, expression, values, parsingConfig, false)
{
}

/// <summary>
/// Initializes a new instance of the <see cref="ExpressionParser"/> class.
/// </summary>
Expand All @@ -71,7 +83,7 @@
/// <param name="values">The values.</param>
/// <param name="parsingConfig">The parsing configuration.</param>
/// <param name="usedForOrderBy">Indicate that this instance will be used for parsing orderBy. Default value is <c>false</c>.</param>
public ExpressionParser(ParameterExpression[]? parameters, string expression, object?[]? values, ParsingConfig? parsingConfig, bool usedForOrderBy = false)
public ExpressionParser(ParameterExpression[]? parameters, string expression, object?[]? values, ParsingConfig? parsingConfig, bool usedForOrderBy)
{
Check.NotEmpty(expression);

Expand Down Expand Up @@ -1438,7 +1450,7 @@
}
else
{
if (!TryGetMemberName(expr, out propName)) // TODO : investigate this

Check warning on line 1453 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
{
if (expr is MethodCallExpression methodCallExpression
&& methodCallExpression.Arguments.Count == 1
Expand Down Expand Up @@ -1920,8 +1932,8 @@
switch (member)
{
case PropertyInfo property:
var propertyIsStatic = property?.GetGetMethod().IsStatic ?? property?.GetSetMethod().IsStatic ?? false;

Check warning on line 1935 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Dereference of a possibly null reference.

Check warning on line 1935 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Dereference of a possibly null reference.

Check warning on line 1935 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Dereference of a possibly null reference.

Check warning on line 1935 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Dereference of a possibly null reference.

Check warning on line 1935 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Dereference of a possibly null reference.
propertyOrFieldExpression = propertyIsStatic ? Expression.Property(null, property) : Expression.Property(expression, property);

Check warning on line 1936 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Possible null reference argument for parameter 'property' in 'MemberExpression Expression.Property(Expression? expression, PropertyInfo property)'.

Check warning on line 1936 in src/System.Linq.Dynamic.Core/Parser/ExpressionParser.cs

View workflow job for this annotation

GitHub Actions / Linux: Build and Tests 

Possible null reference argument for parameter 'property' in 'MemberExpression Expression.Property(Expression? expression, PropertyInfo property)'.
return true;

case FieldInfo field:
Expand Down
Loading