Skip to content

Fix: Add Fallback in ExpressionPromoter to Handle Cache Cleanup in ConstantExpressionHelper #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefH merged 11 commits into from
May 25, 2025
Merged

Fix: Add Fallback in ExpressionPromoter to Handle Cache Cleanup in ConstantExpressionHelper #905

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e8dd351
include ParseRealLiteral tests
RenanCarlosPereira Jun 25, 2024
a27a91f
Change ParseRealLiteral to remove literals before parsing
RenanCarlosPereira Jun 25, 2024
61c656d
Merge master
RenanCarlosPereira Jun 25, 2024
d28c748
NumberParserTests to split the tests NumberParser_Parse[Type]Literal
RenanCarlosPereira Jun 25, 2024
2cf71df
Merge branch 'zzzprojects:master' into master
RenanCarlosPereira Jun 25, 2024
a2098ae
Merge branch 'zzzprojects:master' into master
RenanCarlosPereira Mar 23, 2025
b12b1ae
Fixing race condition
Mar 23, 2025
2b752bf
fix enum tests
Mar 24, 2025
b168256
Update to set instance via reflection
RenanCarlosPereira Apr 7, 2025
2e9cb1a
Update ExpressionPromoterTests.cs
RenanCarlosPereira Apr 7, 2025
f9356e9
using IDynamicLinqCustomTypeProvider
May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
using IDynamicLinqCustomTypeProvider
  • Loading branch information
Renan Pereira committed May 25, 2025
commit f9356e9c5b95786b804aed3d2007b8227c681527
14 changes: 7 additions & 7 deletions test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionPromoterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ public class SampleDto
}

private readonly Mock<IExpressionPromoter> _expressionPromoterMock;
private readonly Mock<IDynamicLinkCustomTypeProvider> _dynamicLinkCustomTypeProviderMock;
private readonly Mock<IDynamicLinqCustomTypeProvider> _dynamicLinqCustomTypeProviderMock;

public ExpressionPromoterTests()
{
_dynamicLinkCustomTypeProviderMock = new Mock<IDynamicLinkCustomTypeProvider>();
_dynamicLinkCustomTypeProviderMock.Setup(d => d.GetCustomTypes()).Returns(new HashSet<Type>());
_dynamicLinkCustomTypeProviderMock.Setup(d => d.ResolveType(It.IsAny<string>())).Returns(typeof(SampleDto));
_dynamicLinqCustomTypeProviderMock = new Mock<IDynamicLinqCustomTypeProvider>();
_dynamicLinqCustomTypeProviderMock.Setup(d => d.GetCustomTypes()).Returns(new HashSet<Type>());
_dynamicLinqCustomTypeProviderMock.Setup(d => d.ResolveType(It.IsAny<string>())).Returns(typeof(SampleDto));

_expressionPromoterMock = new Mock<IExpressionPromoter>();
_expressionPromoterMock.Setup(e => e.Promote(It.IsAny<Expression>(), It.IsAny<Type>(), It.IsAny<bool>(), It.IsAny<bool>())).Returns(Expression.Constant(Guid.NewGuid()));
Expand All @@ -38,7 +38,7 @@ public void DynamicExpressionParser_ParseLambda_WithCustomExpressionPromoter()
var parsingConfig = new ParsingConfig()
{
AllowNewToEvaluateAnyType = true,
CustomTypeProvider = _dynamicLinkCustomTypeProviderMock.Object,
CustomTypeProvider = _dynamicLinqCustomTypeProviderMock.Object,
ExpressionPromoter = _expressionPromoterMock.Object
};

Expand All @@ -52,8 +52,8 @@ public void DynamicExpressionParser_ParseLambda_WithCustomExpressionPromoter()
Assert.NotNull(result);

// Verify
_dynamicLinkCustomTypeProviderMock.Verify(d => d.GetCustomTypes(), Times.Once);
_dynamicLinkCustomTypeProviderMock.Verify(d => d.ResolveType($"{typeof(SampleDto).FullName}"), Times.Once);
_dynamicLinqCustomTypeProviderMock.Verify(d => d.GetCustomTypes(), Times.Once);
_dynamicLinqCustomTypeProviderMock.Verify(d => d.ResolveType($"{typeof(SampleDto).FullName}"), Times.Once);

_expressionPromoterMock.Verify(e => e.Promote(It.IsAny<ConstantExpression>(), typeof(Guid), true, true), Times.Once);
}
Expand Down