This repository was archived by the owner on Jun 18, 2024. It is now read-only.
TC-22656 - Add client-request-id and return-client-request-id for all EWS calls #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Venkatesh-Nadikoppu
commented
Nov 3, 2022
Venkatesh-Nadikoppu
commented
- Added client-request-id to the request
- Need to verify functionality.
HttpClientContext isn't thread safe, and isn't meant for reuse, so create a new one each time it's needed Use a shared cookied store per ExchangeService instance, clearing when necessary ExchangeService is now thread safe, as long as certain properties (meant to be only set once at initialization time) are not changed oftentime while ExchangeService is being used Safely manage HttpClient instances so they're lazy initialized used double checked locking Made fields that can be final final, which improve understability and encourages thread safe design Resolves OfficeDevgh-371
…not our forked version, as the client has fixed the threading issues, see Apache HTTPCLIENT-1715 and HTTPCLIENT-1686
TC-17315 - EWS Library changes
…ials This should address OfficeDev#579
[TC-21422] Add timeout to HttpWebRequest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.