Create example project during repo initialization. Various improvements to repo validation#42
Merged
izeigerman merged 5 commits intomainfrom Dec 13, 2022
Merged
Conversation
izeigerman
commented
Dec 13, 2022
Collaborator
Author
There was a problem hiding this comment.
@vchan I believe that this condition was wrong previously. Can you please validate this and help me make sure that my reasoning is correct.
Collaborator
Author
There was a problem hiding this comment.
Otherwise I'm not sure how did this work before.
Contributor
There was a problem hiding this comment.
Your reasoning looks correct to me. Good catch.
izeigerman
commented
Dec 13, 2022
Collaborator
Author
Collaborator
There was a problem hiding this comment.
I'm going to expand this a bit to include two models (1 incremental and 1 full) and have a dependency between the incremental and full. The thinking is to provide two examples with a dependency.
izeigerman
force-pushed
the
init-example-project-and-validation
branch
from
5bde61e to
5eb4e3f
Compare
tobymao
reviewed
Dec 13, 2022
Contributor
There was a problem hiding this comment.
omg i didn't know you could do this
Collaborator
There was a problem hiding this comment.
+1 I will start using this.
izeigerman
force-pushed
the
init-example-project-and-validation
branch
from
3aea409 to
f5819a4
Compare
izeigerman
force-pushed
the
init-example-project-and-validation
branch
from
f5819a4 to
a85cb13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.