Skip to content

Comments

fix: improve error logging for incomplete refresh terminal state#90

Merged
bh2smith merged 3 commits intoduneanalytics:mainfrom
Olexandr88:fix-refresh-incomplete-state-logging
Dec 28, 2025
Merged

fix: improve error logging for incomplete refresh terminal state#90
bh2smith merged 3 commits intoduneanalytics:mainfrom
Olexandr88:fix-refresh-incomplete-state-logging

Conversation

@Olexandr88
Copy link
Contributor

Improve logging and error message when refresh ends in non-COMPLETED state.

@cursor
Copy link

cursor bot commented Dec 24, 2025

PR Summary

Improve error visibility when refresh ends in non-COMPLETED state

  • In runQuery, replace plain-string logging with structured log.error including message, execution_id, and state
  • Update thrown DuneError to include execution_id and state in the message

Written by Cursor Bugbot for commit 4c33204. Configure here.

Copy link
Collaborator

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks! The indentation looks a bit off - was that intended? I think you need to run the formatter.

🎅

@Olexandr88
Copy link
Contributor Author

Thanks for the warning! This was unintentional. I ran the formatter locally and it didn't change anything it looks like the file is already formatted correctly

@bh2smith
Copy link
Collaborator

@Olexandr88 Olexandr88 requested a review from bh2smith December 26, 2025 10:03
@Olexandr88
Copy link
Contributor Author

Done

@bh2smith
Copy link
Collaborator

bh2smith commented Dec 28, 2025

I have run pnpm fmt on your code and commit the changes. Now it looks good.

Thanks for your PR! I will have it released soon.

@bh2smith bh2smith merged commit 60cb604 into duneanalytics:main Dec 28, 2025
1 of 2 checks passed
@bh2smith bh2smith mentioned this pull request Dec 30, 2025
@bh2smith
Copy link
Collaborator

bh2smith commented Dec 30, 2025

Released: https://github.com/duneanalytics/ts-dune-client/releases/tag/v0.3.5

Thanks again!

@Olexandr88
Copy link
Contributor Author

Please, always happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants