Skip to content

fix: improve error logging for incomplete refresh terminal state #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bh2smith merged 3 commits into from
Dec 28, 2025
Merged

fix: improve error logging for incomplete refresh terminal state #90

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c33204
fix: improve error logging for incomplete refresh terminal state
Olexandr88 Dec 24, 2025
21c5536
style: fix indentation in runQuery error block
Olexandr88 Dec 26, 2025
565cc4f
Format code
bh2smith Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: improve error logging for incomplete refresh terminal state
  • Loading branch information
@Olexandr88
Olexandr88 committed Dec 24, 2025
commit 4c332044c3ecb10ba47c85b5653bc847ac46606d
15 changes: 11 additions & 4 deletions src/api/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,17 @@ export class DuneClient {
if (state === ExecutionState.COMPLETED) {
return this.exec.getExecutionResults(execution_id, args);
} else {
const message = `refresh (execution ${execution_id}) yields incomplete terminal state ${state}`;
// TODO - log the error in constructor
log.error(logPrefix, message);
throw new DuneError(message);
const message = `Refresh returned an incomplete terminal state`;

log.error(logPrefix, {
message,
execution_id,
state,
});

throw new DuneError(
`${message} (execution_id=${execution_id}, state=${state})`
);
}
}

Expand Down
Loading