WIP: support lucene suggestions #2879
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor lucene index implementation.
… them configurable
joewiz
reviewed
Jul 16, 2019
| <text qname="document"> | ||
| <suggest id="document-content"/> | ||
| <field name="content" analyzer="standard"> | ||
| <suggest id="document-text" type="freetext"/> |
Member
There was a problem hiding this comment.
Could you add a test corresponding to this freetext suggestion type?
joewiz
reviewed
Jul 19, 2019
| public final static FunctionSignature[] signatures = { | ||
| new FunctionSignature( | ||
| new QName("suggest", LuceneModule.NAMESPACE_URI, LuceneModule.PREFIX), | ||
| "Return a map of facet labels and counts for the result of a Lucene query.", |
…wrapped analyzer if instance of MetaAnalyzer is passed to suggester.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene provides a package to generate suggestion lists based on an index, which can be presented to users to help formulating a query. This PR integrates the feature into eXist's lucene-based indexing. It also refactors the index package to get a cleaner separation between the lucene full-text index and the range index.
While eXist always had a feature to read index terms via XQuery, this method often fails if the text was passed through an analyzer, e.g. to apply language-dependent stemming to the tokenized text. Lucene's own suggestion package does address this problem, taking analyzers into account properly.
Work in progress, do not merge.
See tests in
extensions/indexes/lucene/src/test/xquery/lucene/suggestions.xql