gh-75261: Propogate use_rawinput to recursive pdb (debug command) by segevfiner · Pull Request #2947 · python/cpython

segevfiner · 2017-07-29T21:07:48Z

This is caused by Lib/pdb.py:1096 which always passes our own current stdin and stdout, and this triggers the conditional in Lib/pdb.py:144-145.

self.stdin and self.stdout are initialized to sys.stdin and sys.stdout respectively when not passed explicitly: Lib/cmd.py:87-94.

See Also: ipython/ipython#10721

https://bugs.python.org/issue31078

Issue: pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the parent pdb uses rawinput #75261

blueyed · 2019-02-15T21:38:52Z

This looks like it might fix readline handling with recursive debugging, e.g. cursor keys being displayed as ^[[D? Is this the case?

segevfiner · 2019-02-27T13:06:03Z

This looks like it might fix readline handling with recursive debugging, e.g. cursor keys being displayed as ^[[D? Is this the case?

Maybe, if the underlying issue was that readline wasn't used in recursive debugging. Feel free to try.

blueyed · 2019-02-27T13:22:09Z

Yay! \o/

Tested with:

def f():
    pass

import pdb
pdb.set_trace()

And then using debug f() on the pdb prompt.
Arrow keys work properly then with this patch, but not without.

blueyed · 2019-02-27T17:02:29Z

@segevfiner
Thanks for this fix.
Please add a news entry for it.
A test would also be awesome, of course - but I cannot say how difficult that is.
(I've also left a comment on https://bugs.python.org/issue31078 to get some attention hopefully)

Patch via python/cpython#2947 (bpo-31078). The test is a bit constructed I guess, but at least something.

Patch via python/cpython#2947 (bpo-31078). No test, since it appears to be hard to simulate cursor keys etc.

blueyed · 2019-03-21T19:18:13Z

            self.error(traceback.format_exception_only(*exc_info)[-1].strip())
            return
        p = Pdb(self.completekey, self.stdin, self.stdout)
+        p.use_rawinput = self.use_rawinput


Could have a comment that this is required because "stdout" is passed.

As for a test, you could inspect frames (similar to pdbpp/pdbpp#169), but not sure if that is really useful / worth it.

(I just came across this again, after having backported it to pdbpp not correctly before - and wrote a test then.. ;) ref)

Patch via python/cpython#2947 (bpo-31078). No test, since it appears to be hard to simulate cursor keys etc.

github-actions · 2022-02-21T00:08:30Z

This PR is stale because it has been open for 30 days with no activity.

…-pdb-rawinput

segevfiner · 2022-02-21T10:25:15Z

Refreshed (Bot seems to bug out and leave the PR as stale)...

github-actions · 2022-03-24T00:08:35Z

This PR is stale because it has been open for 30 days with no activity.

segevfiner · 2022-03-24T00:10:11Z

Spam to mark PR fresh...

MaxwellDupre

Ran test_pdb:
Ran 57 tests in 8.767s
OK
Looks ok.

github-actions · 2022-06-07T00:10:53Z

This PR is stale because it has been open for 30 days with no activity.

arhadthedev · 2023-04-02T07:50:52Z

@iritkatriel (as a more-than-once committer into Lib/pdb.py).

github-actions · 2023-05-03T00:11:00Z

This PR is stale because it has been open for 30 days with no activity.

segevfiner · 2023-05-03T00:12:00Z

Bump No. 5

github-actions · 2023-06-08T00:11:38Z

This PR is stale because it has been open for 30 days with no activity.

segevfiner · 2023-06-08T01:58:31Z

Bump No. 6

github-actions · 2023-07-09T00:14:18Z

This PR is stale because it has been open for 30 days with no activity.

segevfiner · 2023-07-09T06:38:15Z

Bump No. 7

github-actions · 2023-08-10T00:11:43Z

This PR is stale because it has been open for 30 days with no activity.

segevfiner · 2023-08-10T04:50:29Z

Bump No. 8

iritkatriel

A functional change such as this should be committed with a unit test that fails without the change.

Unit tests are important to (1) prevent regression, and (2) clarify what is being changed.

bedevere-bot · 2023-08-10T06:22:59Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ambv · 2023-08-11T14:24:49Z

Closing and re-opening to retrigger CLA checks. Sorry for the noise.

github-actions · 2023-09-11T00:10:15Z

This PR is stale because it has been open for 30 days with no activity.

the-knights-who-say-ni added the CLA signed label Jul 29, 2017

brettcannon added the awaiting review label Feb 2, 2018

blueyed mentioned this pull request Feb 27, 2019

Backport rawinput fix for do_debug pdbpp/pdbpp#140

Closed

blueyed added a commit to pdbpp/pdbpp that referenced this pull request Feb 27, 2019

do_debug: fix setting of use_rawinput

9372f83

Patch via python/cpython#2947 (bpo-31078). The test is a bit constructed I guess, but at least something.

blueyed added a commit to pdbpp/pdbpp that referenced this pull request Feb 28, 2019

do_debug: fix setting of use_rawinput (#141)

abf6bc4

Patch via python/cpython#2947 (bpo-31078). No test, since it appears to be hard to simulate cursor keys etc.

segevfiner force-pushed the bpo-31078-recursive-pdb-rawinput branch from a67fdf5 to a2aed1d Compare March 1, 2019 16:36

segevfiner added 2 commits March 1, 2019 18:38

bpo-31078: Propogate use_rawinput to recursive pdb (debug command)

454e372

Add NEWS.d entry

abdfb28

segevfiner force-pushed the bpo-31078-recursive-pdb-rawinput branch from a2aed1d to abdfb28 Compare March 1, 2019 16:44

blueyed reviewed Mar 21, 2019

View reviewed changes

blueyed added a commit to blueyed/rebased-pdbpp that referenced this pull request May 25, 2019

do_debug: fix setting of use_rawinput (#141)

32ddbf0

Patch via python/cpython#2947 (bpo-31078). No test, since it appears to be hard to simulate cursor keys etc.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 21, 2022

Merge remote-tracking branch 'upstream/main' into bpo-31078-recursive…

8b41a79

…-pdb-rawinput

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 22, 2022

github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 24, 2022

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Mar 25, 2022

MaxwellDupre approved these changes May 7, 2022

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 7, 2022

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 7, 2022

ezio-melotti removed the CLA signed label Jul 13, 2022

Merge branch 'main' into bpo-31078-recursive-pdb-rawinput

0d2b9f2

arhadthedev changed the title ~~bpo-31078: Propogate use_rawinput to recursive pdb (debug command)~~ gh-75261: Propogate use_rawinput to recursive pdb (debug command) Apr 2, 2023

arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Apr 2, 2023

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 3, 2023

github-actions Bot added the stale Stale PR or inactive for long period of time. label May 3, 2023

github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 4, 2023

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 8, 2023

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 9, 2023

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 9, 2023

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 10, 2023

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 10, 2023

iritkatriel requested changes Aug 10, 2023

View reviewed changes

bedevere-bot removed the awaiting core review label Aug 10, 2023

bedevere-bot added the awaiting changes label Aug 10, 2023

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 11, 2023

ambv closed this Aug 11, 2023

ambv reopened this Aug 11, 2023

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 11, 2023

Uh oh!

Conversation

segevfiner commented Jul 29, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueyed commented Feb 15, 2019

Uh oh!

segevfiner commented Feb 27, 2019

Uh oh!

blueyed commented Feb 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueyed commented Feb 27, 2019

Uh oh!

blueyed Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 21, 2022

Uh oh!

segevfiner commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2022

Uh oh!

segevfiner commented Mar 24, 2022

Uh oh!

MaxwellDupre left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 7, 2022

Uh oh!

arhadthedev commented Apr 2, 2023

Uh oh!

github-actions Bot commented May 3, 2023

Uh oh!

segevfiner commented May 3, 2023

Uh oh!

github-actions Bot commented Jun 8, 2023

Uh oh!

segevfiner commented Jun 8, 2023

Uh oh!

github-actions Bot commented Jul 9, 2023

Uh oh!

segevfiner commented Jul 9, 2023

Uh oh!

github-actions Bot commented Aug 10, 2023

Uh oh!

segevfiner commented Aug 10, 2023

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Aug 10, 2023

Uh oh!

ambv commented Aug 11, 2023

Uh oh!

github-actions Bot commented Sep 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

segevfiner commented Jul 29, 2017 •

edited by bedevere-bot

Loading

blueyed commented Feb 27, 2019 •

edited

Loading

blueyed Mar 21, 2019 •

edited

Loading

segevfiner commented Feb 21, 2022 •

edited

Loading